Skip to content

Core tracing prototype options #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Core tracing prototype options #1419

wants to merge 3 commits into from

Conversation

hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Jul 1, 2025 •
edited
Loading

Overview

Prototype of Core Tracing

  • Add two new configuration settings:
    • distributed_tracing.drop_inprocess_spans.enabled - defaulted to False (Only reports entry and exit spans.)
    • distributed_tracing.unique_spans.enabled - defaulted to False (Only reports unique exit spans and entry spans.)
    • distributed_tracing.minimize_attributes.enabled - defaulted to False (Drops all agent attributes that are not entity synthesis attributes from spans)
      Note exit spans are defined as spans that contain entity synthesis agent attributes.
  • Report additional metrics:
    • Time to process dropping spans and attributes. Note: attributes are dropped after attr processing intentionally to make time reporting easier.
    • Approximate amount of bytes or "cost" of core tracing/dropping in-process spans.
  • Double adaptive sampling rate from default of 10 to 20 when Core Tracing is enabled.

Linking ErrorTraces, slow sql etc to distributed traces is not supported in the prototype.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2025 •
edited
Loading

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.89s
✅ MARKDOWN markdownlint 7 0 0 0 1.12s
❌ MARKDOWN markdown-link-check 7 1 0 27.71s
❌ PYTHON ruff 922 2 1 0 1.05s
✅ PYTHON ruff-format 922 11 0 0 0.33s
✅ YAML prettier 13 0 0 0 1.31s
✅ YAML v8r 13 0 0 6.63s
✅ YAML yamllint 13 0 0 0.64s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Jul 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 56.17978% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.34%. Comparing base (777e025) to head (119e5fc).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
newrelic/common/streaming_utils.py 46.29% 28 Missing and 1 partial ⚠️
newrelic/core/node_mixin.py 41.66% 22 Missing and 6 partials ⚠️
newrelic/core/application.py 45.45% 5 Missing and 1 partial ⚠️
newrelic/core/stats_engine.py 76.00% 6 Missing ⚠️
newrelic/config.py 0.00% 3 Missing ⚠️
newrelic/api/transaction.py 66.66% 1 Missing and 1 partial ⚠️
newrelic/core/loop_node.py 33.33% 2 Missing ⚠️
newrelic/core/transaction_node.py 66.66% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (777e025) and HEAD (119e5fc). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (777e025) HEAD (119e5fc)
5 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1419       +/-   ##
===========================================
- Coverage   81.37%   43.34%   -38.04%     
===========================================
  Files         208      208               
  Lines       23554    23699      +145     
  Branches     3716     3742       +26     
===========================================
- Hits        19167    10272     -8895     
- Misses       3129    12370     +9241     
+ Partials     1258     1057      -201

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hmstepanek
hmstepanek commented Jul 7, 2025
View reviewed changes
hmstepanek
hmstepanek commented Jul 7, 2025
View reviewed changes
@hmstepanek hmstepanek force-pushed the core-tracing-prototype-options branch from d83a228 to 282e879 Compare July 9, 2025 23:08
@hmstepanek hmstepanek force-pushed the core-tracing-prototype-options branch from 53b4c30 to 7650f52 Compare July 28, 2025 20:41
@lrafeei lrafeei self-assigned this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lrafeei lrafeei

Labels
tests-failing Tests failing in CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmstepanek @codecov-commenter @lrafeei